[PATCH] D127670: [lld-macho] Fix symbol name returned from InputSection::getLocation

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 02:53:36 PDT 2022


int3 added a comment.

> For the refactor patch: There are usually few symbols per section, so a linear scan is likely faster in practice. Also, this function is only called when emitting errors, so it's not performance-critical anyways, probably. So I guess the motivation for that part is clarity?

Yep, those were my reasons. But yeah no harm changing it to a binary search either since it's not perf-critical


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127670/new/

https://reviews.llvm.org/D127670



More information about the llvm-commits mailing list