[PATCH] D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks.

Rahman Lavaee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 02:18:52 PDT 2022


rahmanl added a comment.

In D121346#3580925 <https://reviews.llvm.org/D121346#3580925>, @jhenderson wrote:

> In D121346#3580806 <https://reviews.llvm.org/D121346#3580806>, @rahmanl wrote:
>
>> Thanks for the explanation. If we use `-function-sections` it also means that we'll generate a unique `LLVM_BB_ADDR_MAP` per function. In this case, I believe the version data will be repeated for every function. Correct? I think we can live with that for now. It's only one or two bytes per function.
>
> Yes, that's what I'd expect. (It's worth noting that -function-sections imposes other overheads like the ELF section header, so a couple of bytes is comparatively small).

Correct, but with the difference that the ELF section header won't be repeated many times in the final linked section, but the version number will.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121346/new/

https://reviews.llvm.org/D121346



More information about the llvm-commits mailing list