[PATCH] D127701: [docs] Minor fixes to CodeGenerator docs

Mon Jun 13 20:12:37 PDT 2022

craig.topper added inline comments.

================
Comment at: llvm/docs/CodeGenerator.rst:291
 whether the instruction has certain target-independent properties (accesses
-memory, is commutable, etc), and holds any target-specific flags.

----------------
DanielMcIntosh-IBM wrote:
> JOE1994 wrote:
> > DanielMcIntosh-IBM wrote:
> > > I don't think this actually improves anything, except maybe removing ambiguity with the other definition of commutable ("allowing regular commuting to and from work"). If anything I feel the existing wording reads better (whether the instruction ... accesses memory, whether the instruction ... is commutable reads better to me than whether the instruction ... is commutative). Unless I'm missing something, this is a matter of personal preference and not worthy of making a change for.
> > Thank you for your comment. My understanding was that the term 'commutable' has only one definition ("allowing regular commuting to and from work"), so I was almost confident that this word was used here by mistake. If the term 'commutable' is already a frequently used term when discussing traits of operators/instructions, I'd be happy to get rid of this change.
> It is a more rare usage/definition, but it is a valid use of it: https://www.collinsdictionary.com/dictionary/english/commutable and https://www.google.com/search?q=define+commutable (that particular search result is sourced from oxford languages)
The property flag this refers to is called `MCID::Commutable`. So it wouldn't make sense to change the documentation without changing that too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127701/new/

https://reviews.llvm.org/D127701