[PATCH] D127705: [DirectX] Support opaque ptr for ValueAsMetadata in DXILBitcodeWriter
Xiang Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 13 19:28:54 PDT 2022
python3kgae marked an inline comment as done.
python3kgae added inline comments.
================
Comment at: llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp:1362
+ if (Function *F = dyn_cast<Function>(V))
+ Ty = TypedPointerType::get(F->getFunctionType(), 0);
+ else if (GlobalVariable *GV = dyn_cast<GlobalVariable>(V))
----------------
arsenm wrote:
> This should also query the address space
Fixed.
Never know Function can have address space before.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127705/new/
https://reviews.llvm.org/D127705
More information about the llvm-commits
mailing list