[PATCH] D127693: [mlgo] Fix accounting for SCC splits

Jin Xin Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 13 13:46:54 PDT 2022


Northbadge created this revision.
Northbadge added a reviewer: mtrofin.
Herald added subscribers: ormris, hiraditya.
Herald added a project: All.
Northbadge requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Previously if the inliner split an SCC such that an empty one remained, the MLInlineAdvisor could potentially lose track of the EdgeCount if a subsequent CGSCC pass modified the calls of a function that was initially in the SCC pre-split. Saving the seen nodes in onPassEntry resolves this.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127693

Files:
  llvm/include/llvm/Analysis/InlineAdvisor.h
  llvm/include/llvm/Analysis/MLInlineAdvisor.h
  llvm/lib/Analysis/MLInlineAdvisor.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/lib/Transforms/IPO/Inliner.cpp
  llvm/test/Transforms/Inline/ML/scc-dead-accounting.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127693.436549.patch
Type: text/x-patch
Size: 8533 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220613/b53cf89d/attachment.bin>


More information about the llvm-commits mailing list