[PATCH] D127681: [RISCV] Disable matchSplatAsGather for i1 vectors to prevent creating illegal nodes.

Mon Jun 13 13:32:42 PDT 2022

craig.topper added a comment.

In D127681#3579256 <https://reviews.llvm.org/D127681#3579256>, @reames wrote:

> LGTM
>
> Minor comments:
>
> - "promote to i1" - I think you meant i8.
> - Is this a broader problem for other types?  e.g. is this a missing legality check on the VGATHER node?

The DAG combine caller already checks isTypeLegal. It's also called by LowerBUILD_VECTOR which should only be called for legal types. I think any legal FP type or non-i1 int type should be ok for the VRGATHER.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127681/new/

https://reviews.llvm.org/D127681