[PATCH] D127689: [inliner] Add per-SCC Inline Advisor printing option

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

overall lgtm, some nits. Also, for the commit message, it's not that the "advisor prints", rather, that we have a way to print at SCC level - if you can rephrase.

Can you also add a test?



================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:109
+/// Allows inline advisor to print content after each CGSCC inliner pass
+static cl::opt<bool> EnableAdvisorPrinting("enable-inline-advisor-printing",
+                                           cl::init(false), cl::Hidden);
----------------
nit: EnablePostSCCAdvisorPrinting / enable-scc-inline-advisor-printing

...just to hint to the reader what the relation with the other printing is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127689/new/

https://reviews.llvm.org/D127689