[PATCH] D127556: gn build: Add support for building the standalone ubsan runtime.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/utils/gn/secondary/compiler-rt/lib/ubsan/BUILD.gn:130
+  inputs = [ "$target_gen_dir/ubsan.vers" ]
+  ldflags = [
+    "-Wl,--version-script," + rebase_path(inputs[0], root_build_dir),
----------------
thakis wrote:
> Should this be gated on `!is_mac && !is_win` or similar?
Yes, but with my changes to lib/BUILD.gn we weren't building this for Windows with this patch. I'll change lib/BUILD.gn to try building for Windows before I submit and roll that back if it doesn't work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127556/new/

https://reviews.llvm.org/D127556