[PATCH] D127679: [RISCV] Implement RISCVTargetLowering::getTargetConstantFromLoad.

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:9393
+
+  switch (Ptr.getMachineOpcode()) {
+  default:
----------------
I may be missing the obvious here, but... if we peak back through an add to find the constant pool entry, don't we need to account for the offset when processing the constant?  

(e.g. if the constant is 8 bytes, but the addi offset was 4, aren't we only loading 4 out of the bytes not the whole constant?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127679/new/

https://reviews.llvm.org/D127679