[PATCH] D127549: RISCV: handle 64-bit PCREL data relocations

[Luís Marques via Phabricator via llvm-commits]

luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM.

(don't forget to update the commit message)



================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:232
+    // TODO: when available, R_RISCV_n_PCREL should be preferred.
+
+    // Avoid pairwise relocations for symbolic difference in debug and .eh_frame
----------------
Nit: maybe clarify that it's been proposed as part of the draft specs for the compact and large code models but not yet adopted. Otherwise people might not know what it's meant by "when available".


================
Comment at: llvm/test/MC/RISCV/riscv64-64b-pcrel.s:1
+# RUN: llvm-mc -triple riscv64-unknown-linux-gnu -filetype obj -o - %s | llvm-readobj -r - | FileCheck %s
+
----------------
Nit: wrap line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127549/new/

https://reviews.llvm.org/D127549