[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

[Mitch Phillips via Phabricator via llvm-commits]

hctim added inline comments.


================
Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:101
+      llvm::ConstantAsMetadata::get(llvm::ConstantInt::get(
+          llvm::Type::getInt1Ty(VMContext), Meta.IsDynInit)),
       llvm::ConstantAsMetadata::get(llvm::ConstantInt::get(
----------------
vitalybuka wrote:
> Meta.IsDynInit -> IsDynInit
> they must be equal, and this legacy code better not use new Meta.
sure. in practice, `Meta.IsDynInit` is exactly equal to `IsDynInit`, but moved it back for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126929/new/

https://reviews.llvm.org/D126929