[PATCH] D127520: [RISCV] Move creation of constant pools from isel to lowering.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2973
+  // All simm32 constants should be handled by isel.
+  if (isInt<32>(Imm))
+    return Op;
----------------
reames wrote:
> Minor: This check should be redundant except maybe as a minor compile time win assuming the count threshold just below is at least 2.  
Agreed, I mainly did it for the compile time win. getMaxBuildIntsCost has a max with 2 in it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127520/new/

https://reviews.llvm.org/D127520