[PATCH] D127580: [VPlan] Remove dead recipes across whole plan.

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 13 08:24:37 PDT 2022


Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

Looks good to me!



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:593
-  case VPBranchOnMaskSC:
-    return false;
   case VPWidenIntOrFpInductionSC:
----------------
Hmm, bug fix? Is there a test that checks it?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.h:53
 
-  /// Try to remove dead recipes. At the moment, only dead header recipes are
-  /// removed.
+  /// Try to remove dead recipes from \p Plan.
   static void removeDeadRecipes(VPlan &Plan);
----------------
nit: comment seems redundant, remove or extend?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127580/new/

https://reviews.llvm.org/D127580



More information about the llvm-commits mailing list