[PATCH] D127640: [docs] Adding DirectX target usage doc

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar accepted this revision.
kuhar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/docs/DirectXUsage.rst:6
+.. warning::
+   Disclaimer: The DirectX backend is experimental and under active development.
+   It is not yet feature complete or ready to be used outside of experimental or
----------------
Consider mentioning how to enable the DX target via cmake


================
Comment at: llvm/docs/DirectXUsage.rst:19
+
+The DirectX target implements the DirectX programability interfaces. These
+interfaces are documented in the `DirectX Specifications. <https://github.com/Microsoft/DirectX-Specs>`_
----------------
programmability?


================
Comment at: llvm/docs/DirectXUsage.rst:76
+specification, but a reference implementation exists in the
+`DirectXShaderCompiler. <https://github.com/microsoft/DirectXShaderCompiler>`_.
+
----------------
nit: double `.`


================
Comment at: llvm/docs/DirectXUsage.rst:78
+
+To support generateing ``DXContainer`` files in LLVM, support is being added to
+the LLVM MC layer for object streamers and writers, and to the Object and
----------------
generating


================
Comment at: llvm/docs/DirectXUsage.rst:78
+
+To support generateing ``DXContainer`` files in LLVM, support is being added to
+the LLVM MC layer for object streamers and writers, and to the Object and
----------------
kuhar wrote:
> generating
consider switching to active voice


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127640/new/

https://reviews.llvm.org/D127640