[PATCH] D126904: [llvm-objdump] Add support for dumping embedded offloading data

[Joseph Huber via Phabricator via llvm-commits]

jhuber6 updated this revision to Diff 436379.
jhuber6 added a comment.

Addressing some comments for now. Let me know if this is sufficient for now, or if I should move to address the other main comments, the section identification scheme and using binary blobs. Improving the tests further would require an implementation of yaml2obj for these binaries. It would be nice to have but I'd need to figure out how to write it, if you have any materials on that it would help. Similarly, it would help if you could point me to where we determine a section's type when we do code generation in LLVM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126904/new/

https://reviews.llvm.org/D126904

Files:
  llvm/test/tools/llvm-objdump/Offload/Inputs/offload-binary.out
  llvm/test/tools/llvm-objdump/Offload/offload-failure.test
  llvm/test/tools/llvm-objdump/Offload/offload.test
  llvm/tools/llvm-objdump/CMakeLists.txt
  llvm/tools/llvm-objdump/ObjdumpOpts.td
  llvm/tools/llvm-objdump/OffloadDump.cpp
  llvm/tools/llvm-objdump/OffloadDump.h
  llvm/tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126904.436379.patch
Type: text/x-patch
Size: 10390 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220613/31ac8f3e/attachment.bin>