[PATCH] D127549: RISCV: handle 64-bit PCREL data relocations

Mon Jun 13 03:38:11 PDT 2022

luismarques added a comment.

In D127549#3574953 <https://reviews.llvm.org/D127549#3574953>, @compnerd wrote:

> I give up; the extra context seems to not paste in properly - the reduced context shows the diff properly.  I can re-upload the extra context variant but it will render improperly.

What exactly was the problem? I applied and regenerated the patch and uploaded it to Phabricator and it seemed fine. I tried it both as a file upload and as a paste.

================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:236
+    // Avoid relaxation for symbolic difference in debug and eh_frame sections
+    if (A.isInSection())
+      return !IsDebugOrEHFrameSection(A.getSection());
----------------
compnerd wrote:
> craig.topper wrote:
> > compnerd wrote:
> > > craig.topper wrote:
> > > > Should relaxation here be relocation?
> > > In the case of a compact code model, we can relax the pair of relocations to a single relocation.  You would still have a relocation, it just is a nominally smaller file, and fewer relocations for the linker to process.
> > I was asking about “Avoid relaxation for symbolic differences…”. Is relaxation the right word there?
> Right; I believe that is the term here - we are technically relaxing the sequence by replacing the two relocations with one.
I've never seen "relaxation" being used that way. While that seems a reasonable generalization of how the term is typically used in compiler land, I suspect most people are going to be confused by the comment.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127549/new/

https://reviews.llvm.org/D127549