[PATCH] D127628: [NewGVN][LoadCoercion][3/3] Replace load with a phi node

[Konstantina Mitropoulou via Phabricator via llvm-commits]

kmitropoulou added inline comments.


================
Comment at: llvm/test/Transforms/NewGVN/basic-cyclic-opt.ll:259
 ; CHECK:       bb3:
-; CHECK-NEXT:    ret i8 0
+; CHECK-NEXT:    [[TMP3:%.*]] = add i8 0, 0
+; CHECK-NEXT:    ret i8 [[TMP3]]
----------------
I need to check why NewGVN does not eliminate the add.


================
Comment at: llvm/test/Transforms/NewGVN/rle-nonlocal.ll:18
+; CHECK-NEXT:    [[C:%.*]] = load i32, i32* [[DEAD]], align 4
+; CHECK-NEXT:    [[D:%.*]] = load i32, i32* [[DEAD]], align 4
+; CHECK-NEXT:    [[E:%.*]] = add i32 [[C]], [[D]]
----------------
I need to investigate this more.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127628/new/

https://reviews.llvm.org/D127628