[PATCH] D127202: [InlineFunction] Handle early exit during getUnderlyingObjects due to MaxLookup

Ting Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 12 22:11:06 PDT 2022


tingwang added inline comments.


================
Comment at: llvm/test/Transforms/Inline/inline-noalias.ll:82
+!28 = !{!27}
+!29 = !{!18, !19, !22, !21, !23}
----------------
nikic wrote:
> nikic wrote:
> > This test case looks like it can be minimized further. Do we need any of the alias.scope/noalias metadata in the input IR? I think we're only interested in what inlining adds. All the arithmetic instructions are probably unnecessary as well. You can also switch to opaque pointer IR to avoid unnecessary types and bitcasts.
> Here is a minimized test case that clearly shows the issue: https://llvm.godbolt.org/z/c8EhMddja
Thank you! This is much simple indeed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127202/new/

https://reviews.llvm.org/D127202



More information about the llvm-commits mailing list