[PATCH] D127123: [AMDGPU] Add more expressive sched_barrier controls

[Austin Kerbow via Phabricator via llvm-commits]

kerbowa added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMFMAIGroupLP.cpp:412
+
+void SchedBarrierDAGMutation::resetSchedBarrierEdges(SUnit &SU) {
+  assert(SU.getInstr()->getOpcode() == AMDGPU::SCHED_BARRIER);
----------------
rampitec wrote:
> This sounds pretty dangerous, at least for non-artifical edges.
Ya. Although I do not think the DAG builder should rely on the sched_barrier having side effects.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127123/new/

https://reviews.llvm.org/D127123