[PATCH] D127118: [AArch64] Autogenerate sve-fixed-length tests. NFC

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 12 03:11:39 PDT 2022


RKSimon added a comment.

In D127118#3569796 <https://reviews.llvm.org/D127118#3569796>, @paulwalker-arm wrote:

> To be honest these tests are just not a good fit for auto-generation, which is why we didn't use `update_llc_test_checks.py` originally.  The best I could come up with is to disable the `NO_SVE` run line when running the script and then enable it afterwards.

That might be an acceptable solution to stop this blocking D127115 <https://reviews.llvm.org/D127115> - by removing the '| FileCheck %s -check-prefix=NO_SVE' the update script will ignore those RUN lines. After that its just a question of manualy adding the FileCheck back and removing the 'NOTE:' top line - we have plenty of test files that are manually adjusted after the update script, removing the 'NOTE' just makes it clearer.

I'd possibly suggest replacing VBITS_EQ_256 with VBITS_GE_256 and adding it the 384 tests as well as the 256 tests (and get rid of the 384 specific checks - sorry my bad).

@paulwalker-arm Would that work or do you think the test refactor is imminent?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127118/new/

https://reviews.llvm.org/D127118



More information about the llvm-commits mailing list