[PATCH] D127134: [llvm] Add DW_CC_nocall to function debug metadata when either return values or arguments are removed

[Venkata Ramanaiah Nalamothu via Phabricator via llvm-commits]

RamNalamothu marked an inline comment as done.
RamNalamothu added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/DeadArgumentElimination.cpp:1093
+    // Change the CallingConvention to DW_CC_nocall
+    NF->getSubprogram()->getType()->setCC(llvm::dwarf::DW_CC_nocall);
+
----------------
dblaikie wrote:
> What happens if there are two subprograms using the same type? Do they both end up getting their CC changed? Maybe this code needs to get the type, duplicate it, then set it?
> 
Ah, yes.

Fixed that. Thank you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127134/new/

https://reviews.llvm.org/D127134