[llvm] 89d2b1e - [X86] emitOrXorXorTree - break if-else chain. NFC.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 11 01:29:08 PDT 2022


Author: Simon Pilgrim
Date: 2022-06-11T09:16:38+01:00
New Revision: 89d2b1e4f756a6ac617a5e6e6b64ef944c001793

URL: https://github.com/llvm/llvm-project/commit/89d2b1e4f756a6ac617a5e6e6b64ef944c001793
DIFF: https://github.com/llvm/llvm-project/commit/89d2b1e4f756a6ac617a5e6e6b64ef944c001793.diff

LOG: [X86] emitOrXorXorTree - break if-else chain. NFC.

(style) Both cases always return.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 37e29d3efd24..9381da436992 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -51338,7 +51338,7 @@ static bool isOrXorXorTree(SDValue X, bool Root = true) {
 
 /// Recursive helper for combineVectorSizedSetCCEquality() to emit the memcmp
 /// expansion.
-template<typename F>
+template <typename F>
 static SDValue emitOrXorXorTree(SDValue X, SDLoc &DL, SelectionDAG &DAG,
                                 EVT VecVT, EVT CmpVT, bool HasPT, F SToV) {
   SDValue Op0 = X.getOperand(0);
@@ -51351,7 +51351,8 @@ static SDValue emitOrXorXorTree(SDValue X, SDLoc &DL, SelectionDAG &DAG,
     if (HasPT)
       return DAG.getNode(ISD::OR, DL, VecVT, A, B);
     return DAG.getNode(ISD::AND, DL, CmpVT, A, B);
-  } else if (X.getOpcode() == ISD::XOR) {
+  }
+  if (X.getOpcode() == ISD::XOR) {
     SDValue A = SToV(Op0);
     SDValue B = SToV(Op1);
     if (VecVT != CmpVT)


        


More information about the llvm-commits mailing list