[PATCH] D127472: [llvm-driver] Add lld

Fri Jun 10 20:58:17 PDT 2022

MaskRay added a comment.

Please add `-DLLVM_TOOL_LLVM_DRIVER_BUILD=on` to the summary. `[llvm-driver]` isn't clear.

Note: by using this, we lose the property to make clang and lld separately profile-guided optimized.

Since you work at Google, can I request that you fix `llvm-project-overlay/lld/BUILD.bazel` similar to `llvm-project-overlay/clang/BUILD.bazel` `clang_main`?
Otherwise it would cause some integration trouble...

================
Comment at: llvm/test/tools/llvm-driver/passthrough-lld.test:4
+# RUN: %llvm ld.lld --help | FileCheck %s
+# RUN: %llvm ld.lld-15 --help | FileCheck %s
+# RUN: %llvm lld -flavor ld.lld --help | FileCheck %s
----------------
may not be necessary to test `-15` variants.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127472/new/

https://reviews.llvm.org/D127472