[PATCH] D127200: [LoongArch] Add codegen support for fneg

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 20:12:26 PDT 2022


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/LoongArch/ir-instruction/fneg.ll:1
+; RUN: llc --mtriple=loongarch32 --mattr=+d < %s | FileCheck %s --check-prefix=LA32
+; RUN: llc --mtriple=loongarch64 --mattr=+d < %s | FileCheck %s --check-prefix=LA64
----------------
Consider placing some arithmetic tests in one file, instead of one file for each instruction.
This may run llc too many times, slowing down testsuite execution.


================
Comment at: llvm/test/CodeGen/LoongArch/ir-instruction/fneg.ll:4
+
+; Exercise the 'fneg' LLVM IR: https://llvm.org/docs/LangRef.html#fneg-instruction
+
----------------
For some test directories, we use `;;` to emphasize non-RUN non-CHECK lines.
This may help update_*_checks.py tools or improve FileCheck to detect some error-prone usage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127200/new/

https://reviews.llvm.org/D127200



More information about the llvm-commits mailing list