[PATCH] D121651: [llvm-profdata] Convert nested profile to CS flat profile.

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:831
+
+  if (ProfileIsCS && ProfileLayout == llvm::sampleprof::SPL_Nest) {
     CSProfileConverter CSConverter(ProfileMap);
----------------
hoy wrote:
> wenlei wrote:
> > The boolean conversion seem to point to hasValue? I think the convention is mostly `*ProfileIsCS`.
> > 
> > > constexpr explicit operator bool() const { return hasValue(); } 
> Here `ProfileLayout` is a function parameter of type `SampleProfileLayout` . 
I was talking about `Optional<bool> ProfileIsCS`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121651/new/

https://reviews.llvm.org/D121651