[PATCH] D127508: [SelectionDAG] Extend WidenVecOp_INSERT_SUBVECTOR to cover more cases.
Paul Walker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 10 09:23:43 PDT 2022
paulwalker-arm added reviewers: efriedma, david-arm, kmclaughlin, sdesmalen.
paulwalker-arm added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:5792-5793
- if (getTypeAction(InVec.getValueType()) == TargetLowering::TypeWidenVector)
- InVec = GetWidenedVector(InVec);
-
----------------
This code looks bogus as a change of `InVec` implies a change of result type and that is something `WidenVecOp_***` should not do. Beforehand I did add an `assert(false)` to verify no existing test exercises the codepath.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127508/new/
https://reviews.llvm.org/D127508
More information about the llvm-commits
mailing list