[PATCH] D127469: [InstCombine] Optimize lshr+shl+and conversion pattern

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 09:14:09 PDT 2022


spatel added a comment.

I don't like increasing risk by combining what are really 2 independent changes into 1 patch. 
Please go back to the earlier revision that only adds the new fold. We can ease the vector restrictions as a second step (I haven't seen any evidence that those cases matter, but it opens up more possibilities to miscompile in ways that are very hard to detect).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127469/new/

https://reviews.llvm.org/D127469



More information about the llvm-commits mailing list