[PATCH] D127438: [gn build][Bazel] Port D127384

Alex Brachet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 08:48:12 PDT 2022


abrachet abandoned this revision.
abrachet marked an inline comment as done.
abrachet added a comment.

This is no longer needed both builds have been ported already



================
Comment at: llvm/utils/gn/build/driver_executable.gni:9
   write_cmake_config("${tool_name}-driver") {
-    input = "//llvm/cmake/driver-template.cpp.in"
+    input = "//llvm/cmake/modules/driver-template.cpp.in"
     output = "$target_gen_dir/${tool_name}-driver.cpp"
----------------
thakis wrote:
> hold up, it's llvm-driver-template.cpp.in. now, with leading "llvm-", right? (Also below.)
Indeed it was. I didn't actually try the patch locally, I just trusted myself to be able to read a file name properly :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127438/new/

https://reviews.llvm.org/D127438



More information about the llvm-commits mailing list