[PATCH] D127477: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 08:28:55 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h:19
 #include "llvm/ADT/StringSwitch.h"
 #include "llvm/CodeGen/MachineInstr.h"
 #include "llvm/MC/MCInstrDesc.h"
----------------
CodeGen header should not be included in this file. This is an MC layer file.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h:437
+namespace RISCVVInstInfo {
+inline static bool isFaultFirstLoad(const MachineInstr &MI) {
+  return MI.getNumExplicitDefs() == 2 && MI.modifiesRegister(RISCV::VL) &&
----------------
This file should not refererence MachineInstr.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127477/new/

https://reviews.llvm.org/D127477



More information about the llvm-commits mailing list