[PATCH] D126774: [InstCombine] Use +0.0 instead of -0.0 as the FP identity for some folds

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 03:19:10 PDT 2022


david-arm added a comment.

In D126774#3566251 <https://reviews.llvm.org/D126774#3566251>, @spatel wrote:

> It would be good to refactor `foldSelectIntoOp()` with a lambda as a preliminary cleanup, so we don't have to duplicate the code. 
> But this is an improvement even without that, so LGTM.

I think cleaning this up makes sense. I'll merge this patch first, then create a follow-on NFC to refactor it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126774/new/

https://reviews.llvm.org/D126774



More information about the llvm-commits mailing list