[PATCH] D127477: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`

Yeting Kuo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 02:10:25 PDT 2022


fakepaper56 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h:437
+namespace RISCVVInstInfo {
+inline static bool isFaultFirstLoad(const MachineInstr &MI) {
+  return MI.getNumExplicitDefs() == 2 && MI.modifiesRegister(RISCV::VL) &&
----------------
RISCVVInstInfo is similar as RISCVInstInfo. Maybe you could write it as static function in RISCVInstInfo. Sorry I ignoring it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127477/new/

https://reviews.llvm.org/D127477



More information about the llvm-commits mailing list