[PATCH] D127062: [JITLink] Remove CodeAlignmentFactor and DataAlignmentFactor validation

Sunho Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 23:29:50 PDT 2022


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6d67f7a3294d: [JITLink][EHFrameSupport] Remove CodeAlignmentFactor and DataAlignmentFactor… (authored by sunho).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127062/new/

https://reviews.llvm.org/D127062

Files:
  llvm/lib/ExecutionEngine/JITLink/EHFrameSupport.cpp


Index: llvm/lib/ExecutionEngine/JITLink/EHFrameSupport.cpp
===================================================================
--- llvm/lib/ExecutionEngine/JITLink/EHFrameSupport.cpp
+++ llvm/lib/ExecutionEngine/JITLink/EHFrameSupport.cpp
@@ -213,10 +213,6 @@
     uint64_t CodeAlignmentFactor = 0;
     if (auto Err = RecordReader.readULEB128(CodeAlignmentFactor))
       return Err;
-    if (CodeAlignmentFactor != 1)
-      return make_error<JITLinkError>("Unsupported CIE code alignment factor " +
-                                      Twine(CodeAlignmentFactor) +
-                                      " (expected 1)");
   }
 
   // Read and validate the data alignment factor.
@@ -224,10 +220,6 @@
     int64_t DataAlignmentFactor = 0;
     if (auto Err = RecordReader.readSLEB128(DataAlignmentFactor))
       return Err;
-    if (DataAlignmentFactor != -8)
-      return make_error<JITLinkError>("Unsupported CIE data alignment factor " +
-                                      Twine(DataAlignmentFactor) +
-                                      " (expected -8)");
   }
 
   // Skip the return address register field.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127062.435809.patch
Type: text/x-patch
Size: 1127 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220610/48770e41/attachment.bin>


More information about the llvm-commits mailing list