[PATCH] D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:449
   }
+  Binary->setProfiledFunctions(ProfiledFunctions);
+}
----------------
Make a copy of this in `ProfileGeneratorBase::collectProfiledFunctions` to keep the function prototype consistent? Actually the function can be made a virtual function.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:465
+
+      if (!Node->getFuncName().empty())
+        if (auto *Func = Binary->getBinaryFunction(Node->getFuncName()))
----------------
Also check FunctionProfile is not null? A null profile means the function is likely not executed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127026/new/

https://reviews.llvm.org/D127026