[PATCH] D127398: [InstCombine] add vector support for (A >> C) == (B >> C) --> (A^B) u< (1 << C)

Chenbing.Zheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 19:21:05 PDT 2022


Chenbing.Zheng added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:4616
+    if (AP1 != AP2)
+      return nullptr;
+    unsigned TypeBits = AP1->getBitWidth();
----------------
RKSimon wrote:
> Does returning here affect any later combines that could have folded? 
This is the only fold of (A >> AP1) == (B >> AP2) so far, and I think it should be moved here when other same pattern appear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127398/new/

https://reviews.llvm.org/D127398



More information about the llvm-commits mailing list