[PATCH] D127206: [LoongArch 6/n] Perform `and` combination with a shifted mask

Lu Weining via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 18:45:47 PDT 2022


SixWeining added a comment.

In D127206#3569149 <https://reviews.llvm.org/D127206#3569149>, @xen0n wrote:

> It seems only the `(x >> shamt) & mask` case is handled, but not `(x & in_place_mask) >> shamt`; is this an intentional simplification? The current behavior is good though.

Thanks for reminding me. `(x & in_place_mask) >> shamt` is not handled in this patch and it indeed can be optimized to `bstrpick` too. But this is for `shl` combination but not for `and`. Please let me handle it in another patch. Thanks again!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127206/new/

https://reviews.llvm.org/D127206



More information about the llvm-commits mailing list