[PATCH] D127369: [Object][COFF] Fix section name parsing error when the name field is not null-padded

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 12:19:54 PDT 2022


mstorsjo accepted this revision.
mstorsjo added a comment.

LGTM, thanks!



================
Comment at: llvm/test/tools/llvm-objdump/COFF/long-section-name.test:18
+
+template = bytes('/4', 'utf-8')
+replacement = b'/4\0abcde'
----------------
Nitpick (and/or I'm not so well versed in python), couldn't this be just `b'/4'` like the line below it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127369/new/

https://reviews.llvm.org/D127369



More information about the llvm-commits mailing list