[PATCH] D127406: llvm-reduce: Support replacing FP values with 1.0

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 11:19:13 PDT 2022


arsenm marked 3 inline comments as done.
arsenm added inline comments.


================
Comment at: llvm/test/tools/llvm-reduce/remove-operands-fp.ll:48
+  %fadd0 = fadd float %arg0, %arg1
+  store float %fadd0, float* undef
+
----------------
aeubanks wrote:
> these store aren't relevant to the test
Still feels weird to be testing dead defs


================
Comment at: llvm/test/tools/llvm-reduce/remove-operands-fp.ll:56
+
+  %fadd3 = fadd <2 x float> %arg2, %arg3
+  store <2 x float> %fadd3, <2 x float>* undef
----------------
aeubanks wrote:
> was this meant to be `zeroinitializer`?
Fixed and rounded out the set to check all of 0/1/undef/nan


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127406/new/

https://reviews.llvm.org/D127406



More information about the llvm-commits mailing list