[PATCH] D127342: [TargetTransformInfo] Added an option for the cache line size

Bardia Mahjour via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 09:50:20 PDT 2022


bmahjour added inline comments.


================
Comment at: llvm/test/Analysis/LoopCacheAnalysis/multi-store.ll:5
+
+; DEFAULT-CACHELINE: Loop 'for.j' has cost = 201000000
+; DEFAULT-CACHELINE-NEXT: Loop 'for.i' has cost = 102000000
----------------
Since the cost of the outer loops are not affected by the cache line size, we can just check the cost for `for.k`. Even better would be to have a simpler test involving a single loop for this (eg modeled after llvm/test/Analysis/LoopCacheAnalysis/PowerPC/compute-cost.ll). Remember the purpose of this test is just to make sure that the option works and that the cost values change with different CLS.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127342/new/

https://reviews.llvm.org/D127342



More information about the llvm-commits mailing list