[PATCH] D127342: [TargetTransformInfo] Added an option for the cache line size

[Bryan Chan via Phabricator via llvm-commits]

bryanpkc added inline comments.


================
Comment at: llvm/lib/Analysis/TargetTransformInfo.cpp:37
+    cl::desc("Use this to specify a cache line size if not provided by the "
+             "target, or to override it."));
+
----------------
This wording is not consistent with the implementation of the option below. In the current implementation, the option always overrides `TTIImpl`, whether `TTIImpl` provides a non-zero cache line size or not.

If you want the option to always override `TTIImpl`, then the option should be named `cache-line-size` not `default-cache-line-size`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127342/new/

https://reviews.llvm.org/D127342