[PATCH] D127165: [DirectX][MC] Add MC support for DXContainer

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 08:46:40 PDT 2022


beanz added inline comments.


================
Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:1015
+  // At the moment the DXBC section should end up empty.
+  TextSection = Ctx->getDXContainerSection("DXBC", SectionKind::getText());
+}
----------------
rengolin wrote:
> What about the DXIL section, do you need to initialise it here, too?
I treat the DXIL section as a data section the same way other backends emit bitcode into sections, so it gets initialized when the global variable emission gets triggered.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127165/new/

https://reviews.llvm.org/D127165



More information about the llvm-commits mailing list