[PATCH] D124561: [lld-macho] Support EH frames under arm64

[Douglas Yung via Phabricator via llvm-commits]

dyung added a comment.

In D124561#3569218 <https://reviews.llvm.org/D124561#3569218>, @uabelho wrote:

> Hello,
>
> When I run tests (check-all) on this commit I get the follwoing two failures:
>
>   Failed Tests (2):
>     lld :: MachO/eh-frame.s
>     lld :: MachO/icf-safe.s
>
> They crash with
>
>   Command Output (stderr):
>   --
>   ld64.lld: ../../lld/MachO/UnwindInfoSection.cpp:216: void lld::macho::UnwindInfoSection::addSymbol(const lld::macho::Defined *): Assertion `!p.first->second->unwindEntry' failed.
>   /repo/uabelho/main-github/llvm/build-all/tools/lld/test/MachO/Output/eh-frame.s.script: line 17: 123869 Aborted                 ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /repo/uabelho/main-github/lld/test/MachO/Inputs/MacOSX.sdk -fatal_warnings -arch arm64 -lSystem -lc++ /repo/uabelho/main-github/llvm/build-all/tools/lld/test/MachO/Output/eh-frame.s.tmp/eh-frame-arm64.o -o /repo/uabelho/main-github/llvm/build-all/tools/lld/test/MachO/Output/eh-frame.s.tmp/eh-frame-arm64
>
> and
>
>   Command Output (stderr):
>   --
>   ld64.lld: ../../lld/MachO/ICF.cpp:451: auto lld::macho::foldIdenticalSections()::(anonymous class)::operator()(lld::macho::ConcatInputSection *) const: Assertion `isec->icfEqClass[0] == 0' failed.
>   ld64.lld: ../../lld/MachO/ICF.cpp:451: auto lld::macho::foldIdenticalSections()::(anonymous class)::operator()(lld::macho::ConcatInputSection *) const: Assertion `isec->icfEqClass[0] == 0' failed.
>   /repo/uabelho/main-github/llvm/build-all/tools/lld/test/MachO/Output/icf-safe.s.script: line 6: 45777 Aborted                 ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /repo/uabelho/main-github/lld/test/MachO/Inputs/MacOSX.sdk -fatal_warnings -arch arm64 -lSystem --icf=safe -dylib -o /repo/uabelho/main-github/llvm/build-all/tools/lld/test/MachO/Output/icf-safe.s.tmp/icf-safe.dylib /repo/uabelho/main-github/llvm/build-all/tools/lld/test/MachO/Output/icf-safe.s.tmp/icf-obj.o
>
> Any idea what's happening?

We are also seeing the same failure on our internal linux build bot, and upstream build bots as well:

- https://lab.llvm.org/buildbot/#/builders/58/builds/23914
- https://lab.llvm.org/buildbot/#/builders/36/builds/21771


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124561/new/

https://reviews.llvm.org/D124561