[PATCH] D127383: Don't treat readnone call in presplit coroutine as not access memory

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 02:38:20 PDT 2022


ChuanqiXu added inline comments.


================
Comment at: llvm/include/llvm/IR/InstrTypes.h:1857
+           // coroutines might resume in different threads.
+           (!getFunction() || !getFunction()->isPresplitCoroutine());
+  }
----------------
nikic wrote:
> As it is now much more extensively used, we probably should convert the `"coroutine.presplit"` attribute into an enum attribute to make these queries less expensive.
Got it. I would convert "coroutine.presplit" into an enum attribute before landing this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127383/new/

https://reviews.llvm.org/D127383



More information about the llvm-commits mailing list