[PATCH] D127253: [AMDGPU] Use v_mad_u64_u32 for IMAD32

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 02:14:16 PDT 2022


rampitec added a comment.

In D127253#3569356 <https://reviews.llvm.org/D127253#3569356>, @foad wrote:

> LGTM, thanks. But we should really do gisel too, even if it means writing C++ code.

I do not really think it needs C++ code. What it needs is a gisel exporter working in a way supporting what sdag can do. Maybe we need to extend tg syntax to extract a specific result from a node. This is my religious belief.

Looking at even sdag code for handling of  mul_lohi I believe this and unnecessary overkill, serving just one purpose: underdeveloped gisel backend.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127253/new/

https://reviews.llvm.org/D127253



More information about the llvm-commits mailing list