[PATCH] D127344: [AMDGPU] Fix hazard handling of v_cmpx to permlane

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 01:37:06 PDT 2022


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM as-is, but perhaps it is time to introduce an "IsCMPX" helper function?

Does this also handle DPP forms of compares?

Maybe add a negative test for v_cmp->permlane since that is part of what you have fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127344/new/

https://reviews.llvm.org/D127344



More information about the llvm-commits mailing list