[PATCH] D124490: [InstrProf] Minimal Block Coverage

Wed Jun 8 18:59:05 PDT 2022

ellis planned changes to this revision.
ellis added a comment.

I am planning changes for now. We might have a simpler algorithm that uses dominator trees. It also runs in linear time, so it's more efficient than the current one.

================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:265
+static cl::opt<bool> PGOBlockCoverage(
+    "pgo-block-coverage", cl::init(false), cl::Hidden, cl::ZeroOrMore,
+    cl::desc(
----------------
MaskRay wrote:
> MaskRay wrote:
> > Delete `, cl::init(false)`
> Also delete `cl::ZeroOrMore`. I have changed `cl::opt` that the option can be specified multiple times without an error.
Nice 🙂

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124490/new/

https://reviews.llvm.org/D124490