[PATCH] D127205: [LoongArch 5/n] Use register R0 (ZERO) for constant 0

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 18:43:05 PDT 2022


myhsu accepted this revision.
myhsu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/LoongArch/LoongArchISelDAGToDAG.cpp:35
   SDLoc DL(Node);
+  MVT VT = Node->getSimpleValueType(0);
 
----------------
nit: is this variable used in any other place? could we either put it in the inner local scope or spell it out in-place?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127205/new/

https://reviews.llvm.org/D127205



More information about the llvm-commits mailing list