[PATCH] D126883: [Debuginfo][DWARF][NFC] Refactor DwarfStringPoolEntryRef.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/DwarfStringPoolEntry.h:52
+  /// Pointer to the dwarf string pool Entry.
+  PointerUnion<ByValStringEntryPtr, ByPtrStringEntryPtr> MapEntry = nullptr;
 
----------------
Instead of a union, would it make sense to template the `DwarfStringPoolEntryRef` in the type it holds? And have a typedef for an OwningDwarfStringPoolEntryRef which is a `DwarfStringPoolEntryRef<DwarfStringPoolEntry>` and a `NonOwningDwarfStringPoolEntryRef` which would be a `DwarfStringPoolEntryRef<DwarfStringPoolEntry>`? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126883/new/

https://reviews.llvm.org/D126883