[PATCH] D127078: llvm-dwarf-dump: include type name for AT_containing_type

[Felipe de Azevedo Piovezan via Phabricator via llvm-commits]

fdeazeve added a comment.

> I'm not aware of any list of "attributes that point to types" and I think DW_AT_type/DW_AT_containing_type covers the interesting cases.  I skimmed the list of all attributes (DWARF v5 section 7.5.4) and nothing obvious caught my eye.

That was my conclusion as well!

>> Or should we change this to work based on the type of the DIE being referenced, instead of the attribute doing the referencing?
>
> That would catch cases like DW_AT_sibling, if the sibling just happened to be a type, and I don't think that's really useful.  (I know LLVM doesn't emit DW_AT_sibling, but it's still out there in the wild and the dumper needs to handle it.)

Thanks for the checking, this is all new to me and I wasn't sure about the answer here.

I'll rebase and give these tests that timeout another try. If nobody else comments in a few days, would one of you be able to help me land this? I don't have commit privileges.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127078/new/

https://reviews.llvm.org/D127078