[PATCH] D125998: [Metadata] Add a resize capability to MDNodes and add a push_back interface to MDNodes.

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added a comment.

In D125998#3565739 <https://reviews.llvm.org/D125998#3565739>, @nikic wrote:

> FYI it looks like this change has some negative effect on compile-time (http://llvm-compile-time-tracker.com/compare.php?from=d572fc3b49bd53b7871223b3054b235cf99f6b61&to=e3f6eda8c6ebc567755377911746d4ca2367e649&stat=instructions) and in `-g` LTO builds on memory usage as well (http://llvm-compile-time-tracker.com/compare.php?from=d572fc3b49bd53b7871223b3054b235cf99f6b61&to=e3f6eda8c6ebc567755377911746d4ca2367e649&stat=max-rss). Is that expected?

I am not surprised by the increased memory usage. The change introduces a resize capability to MDNodes, which when used more often in the future, should improve memory usage overall, especially with LTO. I am concerned about the compile time increase, which is a bit more than I expected. I reverted the patch for other reasons, but I'll check into runtime improvements before I reland.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125998/new/

https://reviews.llvm.org/D125998