[PATCH] D127333: [lld][WebAssembly] Revert moving of data relocations to start function

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 12:02:55 PDT 2022


sbc100 created this revision.
Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, jgravelle-google, dschuff.
Herald added a project: All.
sbc100 requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

Back in https://reviews.llvm.org/D117412 we moved the application of
data reloctions to the wasm start function.

However, because the dynamic linker doesn't know the final addresses
at module instantiation time, this proved to be too early and the
relocations could be applied with the wrong values.

Fixes: https://github.com/emscripten-core/emscripten/issues/17150


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127333

Files:
  lld/test/wasm/data-segments.ll
  lld/test/wasm/pie.ll
  lld/wasm/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127333.435284.patch
Type: text/x-patch
Size: 9998 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220608/61dc239a/attachment.bin>


More information about the llvm-commits mailing list